fix: update P-521 bit length in Web Crypto #2710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ECDH over P-521 returns 66 bytes, i.e. 528 bits. Requesting 521 bits entails a truncation of the derived value, which seems unintended.
achingbrain
changed the title
|
Thanks for opening this PR. Is there a test you could add that shows how it's currently broken in main? The tests are run in node, chrome, firefox, etc so this will help prevent regressions in future. |
|
Hmhm, done :) Btw, the comment in the tests said |
achingbrain
approved these changes
Sep 23, 2024
Like they say, comments become out of date the moment you write them 😆 Thanks for updating the tests 🚀 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECDH over P-521 returns 66 bytes, i.e. 528 bits. Requesting 521 bits causes the last 7 bits of the derived value to be set to 0, which seems unintended (the Node.js version doesn't do this). So, request 66 * 8 bits instead.
Also, remove the superfluous
namedCurveproperty in the algorithm identifier passed toderiveBits(it's only necessary when importing or generating keys).